On Mon, Feb 20, 2023 at 11:12:11PM +0100, Hans de Goede wrote: > Add gpio_keys instantation support to x86_android_tablet_init(), to avoid > this having to be repeated in various x86_dev_info.init() functions. ... > + .gpio_keys_button = &asus_me176c_tf103c_lid, > + .gpio_keys_gpiochip = "INT33FC:02", > + .gpio_keys_pin = 12, Maybe struct x86_gpio_button { struct gpio_keys_button *button; const char *chip; int pin; }; .button = { .button = , .chip = , .pin = , }, ? -- With Best Regards, Andy Shevchenko