On Mon, Feb 20, 2023 at 11:12:04PM +0100, Hans de Goede wrote: > Move the x86-android-tablets code into its own subdir, this is > a preparation patch for splitting the somewhat large file into > multiple smaller files. I'm in favour of the move, but some comments here and there... ... > +# SPDX-License-Identifier: GPL-2.0+ Perhaps switch to "-or-later"? ... > +config X86_ANDROID_TABLETS > + tristate "X86 Android tablet support" > + depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB I'm wondering if we can increase (compile) test coverage by splitting and refactoring like depends on ACPI && EFI depends on (I2C && SPI && SERIAL_DEV_BUS && GPIOLIB) || COMPILE_TEST -- With Best Regards, Andy Shevchenko
