On Sat, Feb 04, 2023 at 12:02:23PM +0100, Hans de Goede wrote:
> acpi_evaluate_dsm_typed() already verifies the type is the requested type,
> so this error check is a no-op, drop it.
Not sure if it's not late...
Reviewed-by: Andy Shevchenko <andy@xxxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
> drivers/platform/x86/intel/int3472/discrete.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/int3472/discrete.c b/drivers/platform/x86/intel/int3472/discrete.c
> index 96963e30ab6c..f064da74f50a 100644
> --- a/drivers/platform/x86/intel/int3472/discrete.c
> +++ b/drivers/platform/x86/intel/int3472/discrete.c
> @@ -78,14 +78,6 @@ skl_int3472_get_sensor_module_config(struct int3472_discrete_device *int3472)
> return ERR_PTR(-ENODEV);
> }
>
> - if (obj->string.type != ACPI_TYPE_STRING) {
> - dev_err(int3472->dev,
> - "Sensor _DSM returned a non-string value\n");
> -
> - ACPI_FREE(obj);
> - return ERR_PTR(-EINVAL);
> - }
> -
> for (i = 0; i < ARRAY_SIZE(int3472_sensor_configs); i++) {
> if (!strcmp(int3472_sensor_configs[i].sensor_module_name,
> obj->string.pointer))
> --
> 2.39.1
>
--
With Best Regards,
Andy Shevchenko
