Hi, On 2/17/23 16:10, Andy Shevchenko wrote: > On Fri, Feb 17, 2023 at 5:00 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> >> The Acer Iconia One 7 B1-750 is a x86 ACPI tablet which ships with Android >> x86 as factory OS. Its DSDT contains a bunch of I2C devices which are not > > a factory > >> actually there, causing various resource conflicts. Enumeration of these >> is skipped through the acpi_quirk_skip_i2c_client_enumeration(). >> >> Add support for manually instantiating the I2C + other devices which are >> actually present on this tablet by adding the necessary device info to >> the x86-android-tablets module. > > ... > I'm not against this patch, but what I have noticed is... > >> + .chip = "INT33FC:02", > > ...this. Can it actually be changed to HID + UID? > > Yes, I know that above probably will in 99.999% cases work, but it's a > little bit fragile. "INT33FC:02" is the gpiochip name and is also used for gpiod_lookup_table entries which also go by gpiochip-name and we cannot just go and change long time used gpiochip names since those are also part of the ioctl GPIO access userspace API. Note by the way that ACPI device enumeration always happens in the same order, so these names are perfectly stable. Regards, Hans
