Hi, On 2/13/23 13:14, Shyam Sundar S K wrote: > It is reported that amd_pmf driver is missing "depends on" for > CONFIG_POWER_SUPPLY causing the following build error. > > ld: drivers/platform/x86/amd/pmf/core.o: in function `amd_pmf_remove': > core.c:(.text+0x10): undefined reference to `power_supply_unreg_notifier' > ld: drivers/platform/x86/amd/pmf/core.o: in function `amd_pmf_probe': > core.c:(.text+0x38f): undefined reference to `power_supply_reg_notifier' > make[1]: *** [scripts/Makefile.vmlinux:34: vmlinux] Error 1 > make: *** [Makefile:1248: vmlinux] Error 2 > > Add this to the Kconfig file. > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217028 > Fixes: c5258d39fc4c ("platform/x86/amd/pmf: Add helper routine to update SPS thermals") > Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/amd/pmf/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/platform/x86/amd/pmf/Kconfig b/drivers/platform/x86/amd/pmf/Kconfig > index c375498c4071..6d89528c3177 100644 > --- a/drivers/platform/x86/amd/pmf/Kconfig > +++ b/drivers/platform/x86/amd/pmf/Kconfig > @@ -6,6 +6,7 @@ > config AMD_PMF > tristate "AMD Platform Management Framework" > depends on ACPI && PCI > + depends on POWER_SUPPLY > select ACPI_PLATFORM_PROFILE > help > This driver provides support for the AMD Platform Management Framework.
