Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v6.2-rc5] [cannot apply to media-tree/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Hans-de-Goede/media-v4l2-core-Make-the-v4l2-core-code-enable-disable-the-privacy-LED-if-present/20230128-131233 patch link: https://lore.kernel.org/r/20230127203729.10205-2-hdegoede%40redhat.com patch subject: [PATCH v6 1/5] media: v4l2-core: Make the v4l2-core code enable/disable the privacy LED if present config: riscv-randconfig-r026-20230123 (https://download.01.org/0day-ci/archive/20230128/202301281534.9Z8xRsrX-lkp@xxxxxxxxx/config) compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 4196ca3278f78c6e19246e54ab0ecb364e37d66a) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install riscv cross compiling tool for clang build # apt-get install binutils-riscv64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/000ccec1824b3256e3fc1a94079bb953f19faab5 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Hans-de-Goede/media-v4l2-core-Make-the-v4l2-core-code-enable-disable-the-privacy-LED-if-present/20230128-131233 git checkout 000ccec1824b3256e3fc1a94079bb953f19faab5 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/media/v4l2-core/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): >> drivers/media/v4l2-core/v4l2-subdev.c:1124:20: error: call to undeclared function 'led_get'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] sd->privacy_led = led_get(sd->dev, "privacy-led"); ^ >> drivers/media/v4l2-core/v4l2-subdev.c:1124:18: error: incompatible integer to pointer conversion assigning to 'struct led_classdev *' from 'int' [-Wint-conversion] sd->privacy_led = led_get(sd->dev, "privacy-led"); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 errors generated. vim +/led_get +1124 drivers/media/v4l2-core/v4l2-subdev.c 1120 1121 int v4l2_subdev_get_privacy_led(struct v4l2_subdev *sd) 1122 { 1123 #if IS_REACHABLE(CONFIG_LEDS_CLASS) > 1124 sd->privacy_led = led_get(sd->dev, "privacy-led"); 1125 if (IS_ERR(sd->privacy_led) && PTR_ERR(sd->privacy_led) != -ENOENT) 1126 return dev_err_probe(sd->dev, PTR_ERR(sd->privacy_led), "getting privacy LED\n"); 1127 1128 if (!IS_ERR_OR_NULL(sd->privacy_led)) { 1129 mutex_lock(&sd->privacy_led->led_access); 1130 led_sysfs_disable(sd->privacy_led); 1131 led_trigger_remove(sd->privacy_led); 1132 led_set_brightness(sd->privacy_led, 0); 1133 mutex_unlock(&sd->privacy_led->led_access); 1134 } 1135 #endif 1136 return 0; 1137 } 1138 EXPORT_SYMBOL_GPL(v4l2_subdev_get_privacy_led); 1139 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
