> On 23-Jan-2023, at 5:07 PM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > Hi All, > > Some apple laptop models have an ACPI device with a HID of APP000B > and that device has an IO resource (so it does not describe the new > unsupported MMIO based gmux type), but there actually is no gmux > in the laptop at all. > > This patch-series improves the drivers/acpi/video_detect.c so that > it no longer tries to use the non present gmux in this case. > > Note I'm still waiting for testing feedback from the reporter of > this problem. But from the logs the problem is clear > (the logs show: "apple_gmux: gmux device not present") and > the detection code is not changed, just moved so these patches > should be fine, but they can definitely use a good review. > > Aditya, can you perhaps test this on a model macbook which does > actually use the apple-gmux driver for backlight control > (assuming you have such a model) ? > Hi Hans Since I own a T2 MacBook, I’ll have to apply some out of tree patches as well from https://github.com/Redecorating/linux/commits/bits/010-gmux. I’ve requested the maintainer although he believes they shouldn't break anything on T2 Macs. I’ve still let a kernel compile without the out of tree patches, just with yours and shall send the outputs by tomorrow.
