Hi, On 1/17/23 23:38, Rishit Bansal wrote: > Add support to map the "HP Omen Key" to KEY_PROG2. Laptops in the HP > Omen Series open the HP Omen Command Center application on windows. But, > on linux it fails with the following message from the hp-wmi driver: > > [ 5143.415714] hp_wmi: Unknown event_id - 29 - 0x21a5 > > Signed-off-by: Rishit Bansal <rishitbansal0@xxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/x86/hp/hp-wmi.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c > index 0a99058be813..d8ba3c483901 100644 > --- a/drivers/platform/x86/hp/hp-wmi.c > +++ b/drivers/platform/x86/hp/hp-wmi.c > @@ -91,6 +91,7 @@ enum hp_wmi_event_ids { > HPWMI_BATTERY_CHARGE_PERIOD = 0x10, > HPWMI_SANITIZATION_MODE = 0x17, > HPWMI_SMART_EXPERIENCE_APP = 0x21, > + HPWMI_OMEN_KEY = 0x1D, > }; > > /* > @@ -219,6 +220,7 @@ static const struct key_entry hp_wmi_keymap[] = { > { KE_KEY, 0x21a9, { KEY_TOUCHPAD_OFF } }, > { KE_KEY, 0x121a9, { KEY_TOUCHPAD_ON } }, > { KE_KEY, 0x231b, { KEY_HELP } }, > + { KE_KEY, 0x21a5, { KEY_PROG2 }}, /* HP Omen Key */ > { KE_END, 0 } > }; > > @@ -810,6 +812,7 @@ static void hp_wmi_notify(u32 value, void *context) > case HPWMI_SMART_ADAPTER: > break; > case HPWMI_BEZEL_BUTTON: > + case HPWMI_OMEN_KEY: > key_code = hp_wmi_read_int(HPWMI_HOTKEY_QUERY); > if (key_code < 0) > break;
