On Fri, 20 Jan 2023, Linus Walleij wrote: > On Thu, Jan 19, 2023 at 2:01 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > > Add a generic [devm_]led_get() method which can be used on both devicetree > > and non devicetree platforms to get a LED classdev associated with > > a specific function on a specific device, e.g. the privacy LED associated > > with a specific camera sensor. > > > > Note unlike of_led_get() this takes a string describing the function > > rather then an index. This is done because e.g. camera sensors might > > have a privacy LED, or a flash LED, or both and using an index > > approach leaves it unclear what the function of index 0 is if there is > > only 1 LED. > > > > This uses a lookup-table mechanism for non devicetree platforms. > > This allows the platform code to map specific LED class_dev-s to a specific > > device,function combinations this way. > > > > For devicetree platforms getting the LED by function-name could be made > > to work using the standard devicetree pattern of adding a -names string > > array to map names to the indexes. > > > > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > --- > > Changes in v4: > > - Split out support for led_get() devicetree name-based lookup support > > into a separate RFC patch as there currently are no user for this > > - Use kstrdup_const() / kfree_const() for the led_name > > This is how I would implement it so: > Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Thanks Linus, this is all really helpful. -- Lee Jones [李琼斯]
