On Tue, Jan 17, 2023 at 10:34:40PM +0100, Thomas Gleixner wrote: > On Mon, Jan 16 2023 at 14:50, Johan Hovold wrote: > > -int __irq_domain_alloc_irqs(struct irq_domain *domain, int irq_base, > > - unsigned int nr_irqs, int node, void *arg, > > - bool realloc, const struct irq_affinity_desc *affinity) > > +static int ___irq_domain_alloc_irqs(struct irq_domain *domain, int irq_base, > > + unsigned int nr_irqs, int node, void *arg, > > + bool realloc, const struct irq_affinity_desc *affinity) > > __ vs. ___ is almost undistinguishable. > > irq_domain_alloc_irqs_locked() nicely explains what this is about, no? Yeah, wasn't too happy about those three underscores either, but with the exported function unfortunately already having a double underscore prefix... I'll try switching to a 'locked' suffix instead. Johan