Hi, On 12/14/22 10:49, Mattia Dongili wrote: > On Wed, 14 Dec 2022 at 18:13, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> >> Hi Mattia, >> >> On 12/14/22 09:55, Mattia Dongili wrote: >>> On Tue, 13 Dec 2022 at 21:29, Hans de Goede <hdegoede@xxxxxxxxxx <mailto:hdegoede@xxxxxxxxxx>> wrote: >>> >>> The 0x153 version of the kbd backlight control SNC handle has no separate >>> address to probe if the backlight is there. >>> >>> This turns the probe call into a set keyboard backlight call with a value >>> of 0 turning off the keyboard backlight. >>> >>> Skip probing when there is no separate probe address to avoid this. >>> >>> Link: https://bugzilla.redhat.com/show_bug.cgi?id=1583752 <https://bugzilla.redhat.com/show_bug.cgi?id=1583752> >>> Fixes: 800f20170dcf ("Keyboard backlight control for some Vaio Fit models") >>> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx <mailto:hdegoede@xxxxxxxxxx>> >>> >>> >>> Signed-off-by: Mattia Dongili <malattia@xxxxxxxx <mailto:malattia@xxxxxxxx>> >>> >>> >>> --- >>> drivers/platform/x86/sony-laptop.c | 21 ++++++++++++++------- >>> 1 file changed, 14 insertions(+), 7 deletions(-) >>> >>> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c >>> index 765fcaba4d12..5ff5aaf92b56 100644 >>> --- a/drivers/platform/x86/sony-laptop.c >>> +++ b/drivers/platform/x86/sony-laptop.c >>> @@ -1888,14 +1888,21 @@ static int sony_nc_kbd_backlight_setup(struct platform_device *pd, >>> break; >>> } >>> >>> - ret = sony_call_snc_handle(handle, probe_base, &result); >>> - if (ret) >>> - return ret; >>> + /* >>> + * Only probe if there is a separate probe_base, otherwise the probe call >>> + * is equivalent to __sony_nc_kbd_backlight_mode_set(0), resulting in >>> + * the keyboard backlight being turned off. >>> + */ >>> + if (probe_base) { >>> + ret = sony_call_snc_handle(handle, probe_base, &result); >>> + if (ret) >>> + return ret; >>> >>> - if ((handle == 0x0137 && !(result & 0x02)) || >>> - !(result & 0x01)) { >>> - dprintk("no backlight keyboard found\n"); >>> - return 0; >>> + if ((handle == 0x0137 && !(result & 0x02)) || >>> + !(result & 0x01)) { >>> + dprintk("no backlight keyboard found\n"); >>> + return 0; >>> + } >>> } >>> >>> kbdbl_ctl = kzalloc(sizeof(*kbdbl_ctl), GFP_KERNEL); >>> -- >>> 2.38.1 >>> >>> --- >>> >>> Aha, looking at the bug report and the commit that caused it I think this fix makes sense. >>> You can add my sign-off too. >> >> I think you mean Reviewed-by? Singed-off-by: is only for patches passing >> through you. E.g. it was send to you personally and you then submit it >> to the list. > > Sigh yeah... It's been too long. > > Reviewed-by: Mattia Dongili <malattia@xxxxxxxx> Thanks. I've added this to my review-hans (soon to be for-next) branch now. Regards, Hans
