Re: [PATCH 1/1] apu6: add apu6 variation to apu2 driver family

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> On Dec 31, 2022, at 4:06 AM, Ed Wildgoose <ed@xxxxxxxxxxxxxx> wrote:
> 
> 
> On 30/12/2022 18:07, Philip Prindeville wrote:
>> From: Philip Prindeville <philipp@xxxxxxxxxxxxxxxxxxxxx>
>> 
>> Add detection of PC Engines "apu6" platform via DMI.
>> 
>> Also, revise leds-apu.c to call out additional platforms
>> which aren't supported.
> 
> 
> Any chance of also adding the APU5? Details in my previous patches
> 
> Ed W
> 


Sure, but I have questions about this:

+       /* APU5 w/ mainline BIOS */
+       {
+               .ident          = "apu5",
+               .matches        = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "PC Engines"),
+                       DMI_MATCH(DMI_BOARD_NAME, "apu5")
+               },
+               .driver_data    = (void *)&apu5_driver_data,
+       },

All the other entries have their .driver_data pointing to a struct amd_fch_gpio_pdata... but not this one.  It points to a struct apu_driver_data and I don't even see the definition of that type.  Should it point to "board_apu5" instead and we can drop:

+static const struct amd_fch_gpio_pdata board_apu5 = {
+       .gpio_num       = ARRAY_SIZE(apu5_gpio_regs),
+       .gpio_reg       = apu5_gpio_regs,
+       .gpio_names     = apu5_gpio_names,
+};
+






[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux