On Tue, Dec 13, 2022 at 2:29 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
>
> The 0x153 version of the kbd backlight control SNC handle has no separate
> address to probe if the backlight is there.
>
> This turns the probe call into a set keyboard backlight call with a value
> of 0 turning off the keyboard backlight.
>
> Skip probing when there is no separate probe address to avoid this.
...
> + /*
> + * Only probe if there is a separate probe_base, otherwise the probe call
> + * is equivalent to __sony_nc_kbd_backlight_mode_set(0), resulting in
> + * the keyboard backlight being turned off.
> + */
> + if (probe_base) {
I'm wondering if it wouldn't be better to split this into the helper
and hence just call it here.
> }
--
With Best Regards,
Andy Shevchenko
