Hi Jorge, On 12/2/22 18:36, Jorge Lopez wrote: > Version 5 restructures the patches submitted in previous versions. > Earlier hp-bioscfg patches were squashed together before creating > the new split. > > Version 5.0 breaks down the changes into 5 patches > > The driver files were broken down in 5 patches of 3 files each > with exception of patch 1/5 > > Jorge Lopez (5): > Introduction of HP-BIOSCFG driver (1) > Introduction of HP-BIOSCFG driver (2) > Introduction of HP-BIOSCFG driver (3) > Introduction of HP-BIOSCFG driver (4) > Introduction of HP-BIOSCFG driver (5) Thank you for the new version. Unfortunately I don't have time atm to review this. And the next 2 weeks are the merge window, followed by 2 weeks of christmas vacation. So I'm afraid that I likely won't get around to reviewing this until the week of January 9th. Regards, Hans > > .../testing/sysfs-class-firmware-attributes | 181 ++- > MAINTAINERS | 6 + > drivers/platform/x86/hp/Kconfig | 16 + > drivers/platform/x86/hp/Makefile | 1 + > drivers/platform/x86/hp/hp-bioscfg/Makefile | 19 + > .../x86/hp/hp-bioscfg/biosattr-interface.c | 283 +++++ > drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 1066 +++++++++++++++++ > drivers/platform/x86/hp/hp-bioscfg/bioscfg.h | 673 +++++++++++ > .../x86/hp/hp-bioscfg/enum-attributes.c | 499 ++++++++ > .../x86/hp/hp-bioscfg/int-attributes.c | 450 +++++++ > .../x86/hp/hp-bioscfg/ordered-attributes.c | 549 +++++++++ > .../x86/hp/hp-bioscfg/passwdattr-interface.c | 51 + > .../x86/hp/hp-bioscfg/passwdobj-attributes.c | 631 ++++++++++ > .../x86/hp/hp-bioscfg/spmobj-attributes.c | 419 +++++++ > .../x86/hp/hp-bioscfg/string-attributes.c | 425 +++++++ > .../x86/hp/hp-bioscfg/sureadmin-attributes.c | 1014 ++++++++++++++++ > .../x86/hp/hp-bioscfg/surestart-attributes.c | 149 +++ > 17 files changed, 6430 insertions(+), 2 deletions(-) > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/Makefile > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/biosattr-interface.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/bioscfg.h > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/int-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/ordered-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/passwdattr-interface.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/string-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/sureadmin-attributes.c > create mode 100644 drivers/platform/x86/hp/hp-bioscfg/surestart-attributes.c >