Hi, On 11/30/22 11:03, Andy Shevchenko wrote: > On Wed, Nov 30, 2022 at 1:12 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: >> >> Hi All, >> >> The out of tree IPU6 driver has moved to using the in kernel INT3472 >> code for doing power-ctrl rather then doing their own thing (good!). > > than > >> Some of the IPU6 devices with a discrete INT3472 ACPI device have a >> privacy-led GPIO. but no clk-enable GPIO. To make this work this series >> moves the privacy LED control from being integrated with the clk-provider >> to modelling the privacy LED as a separate GPIO. This also brings the >> discrete INT3472 ACPI device privacy LED handling inline with the privacy >> LED handling for INT3472 TPS68470 PMIC devices which I posted here: >> >> https://lore.kernel.org/platform-driver-x86/20221128214408.165726-1-hdegoede@xxxxxxxxxx/ >> >> This obsoletes my previous "[PATCH 0/3] platform/x86: int3472/discrete: >> Make it work with IPU6" series: >> >> https://lore.kernel.org/platform-driver-x86/20221124200007.390901-1-hdegoede@xxxxxxxxxx/ >> >> Mauro since laptops with IPU6 cameras are becoming more and more >> popular I would like to get this merged for 6.2 so that with 6.2 >> users will be able to build the out of tree IPU6 driver without >> requiring patching their main kernel. I realize we are a bit >> late in the cycle, but can you please still take the ov5693 patch >> for 6.2 ? It is quite small / straight-forward and since it used >> gpiod_get_optional() it is a no-op without the rest of this series. >> >> This series has been tested on: >> >> - Lenovo ThinkPad X1 Yoga gen 7, IPU6, front: ov2740 with privacy LED >> - Dell Latitude 9420, IPU 6 with privacy LED on front >> - Mirosoft Surface Go, IPU3, front: ov5693 with privacy LED, > > Microsoft? Ack. >> back: ov8865 with privacy LED > > I like this series! Minimum invasion and code. I'm glad you like it and thank you for the review. Regards, Hans
