On Tue, Nov 29, 2022 at 01:20:03PM +0100, Hans de Goede wrote: > On 11/29/22 12:59, Andy Shevchenko wrote: ... > I'm sorry, but just like with your comments on patch 1/3 > I really don't see the problem here. Unlike "dir" or "out_or_in" > get is a perfectly fine parameter name which is actually clearly > defined by the parameter-name itself. > > And the function + the callers are all in the same file, so > anyone reading the code can easily deduce the meaning from > the code. OK. I'm not insisting, it's a bikeshedding anyway. -- With Best Regards, Andy Shevchenko