On Tue, Nov 29, 2022 at 1:27 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > On 11/29/22 11:22, Andy Shevchenko wrote: > > On Mon, Nov 28, 2022 at 11:44 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > >> > >> For the regular GPIO pins the value should be read from TPS68470_REG_GPDI, > >> so that the actual value of the pin is read, rather then the value the pin > > > > than > > Ack. > > >> would output when put in output mode. > > > > I don't see it here and haven't checked the context, but the idea is > > to check the direction and return either input (if pin is in input > > mode) or [cached] output.If it's the case, the patch looks good to me. > > No the idea is to always actually use the input register when reading > the pins, independent of the input/output mode. Instead of always > reading the [cached] output register value. But why? This makes a little sense to me. > The input buffer will still work when the device is in output mode Does this hardware support HiZ? > and if somehow an external force is pushing the pin low/high against > the output value then the input buffer will correctly reflect this > (assuming the output is current limited and thus the magic smoke > stays inside the chip). Exactly, when smoke comes out, the hardware is broken and code, whatever is it, makes no difference at all. -- With Best Regards, Andy Shevchenko
