On Thu, 16 Nov 2022 at 18:19, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Hi, Hi, sorry for the late reply. > On 11/11/22 12:44, Maxim Mikityanskiy wrote: > > Maybe also add a module parameter to force the i8042 workaround? This > > change is likely to break the touchpad toggle for some devices similar > > to Z570 (maybe Z580? Y580? idk), so people would at least have an > > option to force enable it using the module parameter, before the > > relevant entry gets added to the DMI table, the patch gets merged, and > > the kernel gets updated. > > That is a good idea. I'm about to send out this as a proper patch-series > and I've added a module parameter to the version. Alright, I will continue the discussion from there then. > BTW did you ever try simply writing back the value returned from > VPCCMD_R_TOUCHPAD to VPCCMD_W_TOUCHPAD ? > > Eray has been looking at what the Windows tools do and according > to Eray they always call VPCCMD_W_TOUCHPAD on touchpad toggle > events. So maybe just writing back the value is enough to actually > disable the touchpad ? It isn't, as I said before, VPCCMD_W_TOUCHPAD is nulled/empty on Z570 and S12, so it won't work. Best, Eray
