On Mon, Nov 07, 2022 at 02:53:13PM -0800, Jithu Joseph wrote:
> IFS uses 'scan test images' provided by Intel that can be regarded as
Why is that in '' quotes?
> firmware. IFS test image carries microcode header with extended signature
> table.
>
> Expose find_matching_signature() for verifying if the test image
Yeah, not "expose" but "reuse".
> header or the extended signature table indicate whether an IFS test image
> is fit to run on a system.
> Move the function to cpu/intel.c and
> add intel_ prefix to the function name.
That is not needed in a commit message - it is visible from the diff
itself.
Please remove the "what" in all your commit messages.
...
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
