On Sun, 06 Nov 2022, Dawei Li wrote:
> For bus-based driver, device removal is implemented as:
> 1 device_remove()->
> 2 bus->remove()->
> 3 driver->remove()
>
> Driver core needs _no_ inform from callee(bus driver) about the
> result of remove callback. In that case,
> commit <fc7a6209d571> ("bus: Make remove callback return void")
> forces struct bus_type::remove() be void-returned.
>
> Now we have the situation that both 1 & 2 of calling chain are
> void-returned, so it does _not_ make much sense for 3(driver->remove)
> to return non-void to its caller.
>
> So the basic idea behind this change is making remove() callback of
> any bus-based driver to be void-returned.
>
> This change itself, is for device drivers based on acpi-bus.
>
> Signed-off-by: Dawei Li <set_pte_at@xxxxxxxxxxx>
> ---
> arch/ia64/hp/common/aml_nfw.c | 4 ++--
> arch/x86/platform/olpc/olpc-xo15-sci.c | 3 +--
> drivers/acpi/ac.c | 8 +++-----
> drivers/acpi/acpi_pad.c | 3 +--
> drivers/acpi/acpi_video.c | 8 +++-----
> drivers/acpi/battery.c | 5 ++---
> drivers/acpi/button.c | 5 ++---
> drivers/acpi/ec.c | 5 ++---
> drivers/acpi/hed.c | 3 +--
> drivers/acpi/nfit/core.c | 3 +--
> drivers/acpi/sbs.c | 9 ++++-----
> drivers/acpi/sbshc.c | 7 +++----
> drivers/acpi/thermal.c | 7 +++----
> drivers/acpi/tiny-power-button.c | 10 +++++++---
> drivers/char/sonypi.c | 3 +--
> drivers/char/tpm/tpm_crb.c | 4 +---
> drivers/hv/vmbus_drv.c | 4 +---
> drivers/hwmon/acpi_power_meter.c | 5 ++---
> drivers/hwmon/asus_atk0110.c | 6 ++----
> drivers/input/misc/atlas_btns.c | 4 +---
> drivers/net/fjes/fjes_main.c | 4 +---
> .../platform/chrome/chromeos_privacy_screen.c | 3 +--
> drivers/platform/chrome/wilco_ec/event.c | 4 +---
> drivers/platform/surface/surfacepro3_button.c | 3 +--
> drivers/platform/x86/asus-laptop.c | 3 +--
> drivers/platform/x86/asus-wireless.c | 3 +--
> drivers/platform/x86/classmate-laptop.c | 20 +++++++++----------
> drivers/platform/x86/dell/dell-rbtn.c | 6 ++----
> drivers/platform/x86/eeepc-laptop.c | 3 +--
> drivers/platform/x86/fujitsu-laptop.c | 4 +---
> drivers/platform/x86/fujitsu-tablet.c | 3 +--
> drivers/platform/x86/intel/rst.c | 4 +---
> drivers/platform/x86/lg-laptop.c | 4 +---
> drivers/platform/x86/panasonic-laptop.c | 8 +++-----
> drivers/platform/x86/sony-laptop.c | 9 +++------
> drivers/platform/x86/system76_acpi.c | 4 +---
> drivers/platform/x86/topstar-laptop.c | 3 +--
> drivers/platform/x86/toshiba_acpi.c | 4 +---
> drivers/platform/x86/toshiba_bluetooth.c | 6 +++---
> drivers/platform/x86/toshiba_haps.c | 4 +---
> drivers/platform/x86/wireless-hotkey.c | 3 +--
> drivers/platform/x86/xo15-ebook.c | 3 +--
> drivers/ptp/ptp_vmw.c | 3 +--
> drivers/thermal/intel/intel_menlow.c | 8 +++-----
> drivers/video/backlight/apple_bl.c | 3 +--
Acked-by: Lee Jones <lee@xxxxxxxxxx>
> drivers/watchdog/ni903x_wdt.c | 4 +---
> drivers/xen/xen-acpi-pad.c | 3 +--
> include/acpi/acpi_bus.h | 2 +-
> 48 files changed, 88 insertions(+), 149 deletions(-)
--
Lee Jones [李琼斯]
