On Wed, 2022-11-02 at 12:46 +0200, Andy Shevchenko wrote: > On Tue, Nov 01, 2022 at 12:10:18PM -0700, David E. Box wrote: > > Add support for reading the meter certificate from Intel On Demand > > hardware. The meter certificate [1] is used to access the utilization > > metrics of enabled features in support of the Intel On Demand consumption > > model. Similar to the state certificate, the meter certificate is read by > > mailbox command. > > > > [1] > > https://github.com/intel-sandbox/debox1.intel_sdsi/blob/gnr-review/meter-certificate.rst > > Link: tag? > > ... > > > static BIN_ATTR(state_certificate, 0400, state_certificate_read, NULL, > > SDSI_SIZE_READ_MSG); > > BIN_ATTR_ADMiN_RO() ? > > ... > > > +static BIN_ATTR(meter_certificate, 0400, meter_certificate_read, NULL, > > SDSI_SIZE_READ_MSG); > > Ditto. > Ack on all. Thanks Andy.