On 11/2/2022 12:03 PM, Borislav Petkov wrote: > On Fri, Oct 21, 2022 at 01:34:04PM -0700, Jithu Joseph wrote: >> IFS uses 'scan test images' provided by Intel that can be regarded as >> firmware. IFS test image carries microcode header with extended signature >> table. >> >> Expose find_matching_signature() for verifying if the test image >> header or the extended signature table indicate whether an IFS test image >> is fit to run on a system. Add microcode_intel_ prefix to the >> function name. > > This doesn't look like the right design to me: > > If this is going to be generic CPU-vendor related code which other > facilities like the microcode loader can use, then the prefix should be > intel_<bla>. Just like intel_cpu_signatures_match(). > > Then that code should either be in a lib-like compilation unit or simply > in arch/x86/kernel/cpu/intel.c. Just like intel_cpu_signatures_match(). Will rename the function to intel_find_matching_signature() and move it to to arch/x86/kernel/cpu/intel.c as you suggest above and add its declaration to arch/x86/include/asm/cpu.h (where intel_cpu_signatures_match() is defined) Jithu
