[Public] > -----Original Message----- > From: Hans de Goede <hdegoede@xxxxxxxxxx> > Sent: Monday, October 31, 2022 16:26 > To: Rafael J . Wysocki <rafael@xxxxxxxxxx> > Cc: Hans de Goede <hdegoede@xxxxxxxxxx>; Len Brown > <lenb@xxxxxxxxxx>; linux-acpi@xxxxxxxxxxxxxxx; platform-driver- > x86@xxxxxxxxxxxxxxx; Daniel Dadap <ddadap@xxxxxxxxxx> > Subject: [PATCH] ACPI: video: Add backlight=native DMI quirk for Dell G15 > 5515 > > The Dell G15 5515 has the WMI interface (and WMI call returns) expected > by the nvidia-wmi-ec-backlight interface. But the backlight class device > registered by the nvidia-wmi-ec-backlight driver does not actually work. > Is there a way to detect this from nvidia-wmi-ec-backlight? I would think it's cleaner to have that driver return -ENODEV so you end up with just the "working" amdgpu_bl0. > The amdgpu_bl0 native GPU backlight class device does actually work, > add a backlight=native DMI quirk for this. > > Cc: Daniel Dadap <ddadap@xxxxxxxxxx> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > drivers/acpi/video_detect.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c > index 841f6213b4de..88acc09773bb 100644 > --- a/drivers/acpi/video_detect.c > +++ b/drivers/acpi/video_detect.c > @@ -645,6 +645,16 @@ static const struct dmi_system_id > video_detect_dmi_table[] = { > }, > }, > > + /* Models which have nvidia-ec-wmi support, but should not use it. > */ > + { > + .callback = video_detect_force_native, > + /* Dell G15 5515 */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15 5515"), > + }, > + }, > + > /* > * Desktops which falsely report a backlight and which our heuristics > * for this do not catch. > -- > 2.37.3