El dom, 30 oct 2022 a la(s) 21:03, Barnabás Pőcze (pobrn@xxxxxxxxxxxxxx) escribió: > > Hi > > > 2022. október 30., vasárnap 21:32 keltezéssel, Joaquín Ignacio Aramendía írta: > > > Sensors driver for OXP Handhelds from One-Netbook that expose fan reading > > and control via hwmon sysfs. > > > > As far as I could gather all OXP boards have the same DMI strings and > > they are told appart by the boot cpu vendor (Intel/AMD). > > Currently only AMD boards are supported. > > > > Fan control is provided via pwm interface in the range [0-255]. AMD > > boards have [0-100] as range in the EC, the written value is scaled to > > accommodate for that. > > > > Signed-off-by: Joaquín Ignacio Aramendía <samsagax@xxxxxxxxx> > > --- > > Rewritten the driver according to feedback, checkpatch passes, removed > > unnecessary complexity and moved the driver to hwmon > > --- > > drivers/hwmon/Kconfig | 13 +- > > drivers/hwmon/Makefile | 1 + > > drivers/hwmon/oxp-sensors.c | 278 ++++++++++++++++++++++++++++++++++++ > > 3 files changed, 291 insertions(+), 1 deletion(-) > > create mode 100644 drivers/hwmon/oxp-sensors.c > > > > [...] > > diff --git a/drivers/hwmon/oxp-sensors.c b/drivers/hwmon/oxp-sensors.c > > new file mode 100644 > > index 000000000000..128fdf4c46e2 > > --- /dev/null > > +++ b/drivers/hwmon/oxp-sensors.c > > @@ -0,0 +1,278 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +/* > > + * Platform driver for OXP Handhelds that expose fan reading and control > > + * via hwmon sysfs. > > + * > > + * All boards have the same DMI strings and they are told appart by the > > + * boot cpu vendor (Intel/AMD). Currently only AMD boards are supported > > + * but the code is made to be simple to add other handheld boards in the > > + * future. > > + * Fan control is provided via pwm interface in the range [0-255]. AMD > > + * boards use [0-100] as range in the EC, the written value is scaled to > > + * accommodate for that. > > + * > > + * PWM control is disabled by default, can be enabled via module parameter. > > As far as I can see this is not true anymore. True. Will remove that. Also I found a typo on my registers that needs to be fixed > > Also, have you checked if there is maybe a WMI interface for this? There is not as far as I can tell. Even on Windows the fan control app uses EC registers directly. -- Joaquín I. Aramendía
