Re: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN()
From: Sven van Ashbrook <svenva@xxxxxxxxxxxx>
Date: Sat, 29 Oct 2022 00:11:32 -0400
Cc: "Limonciello, Mario" <Mario.Limonciello@xxxxxxx>, LKML <linux-kernel@xxxxxxxxxxxxxxx>, "S-k, Shyam-sundar" <Shyam-sundar.S-k@xxxxxxx>, "rrangel@xxxxxxxxxxxx" <rrangel@xxxxxxxxxxxx>, "platform-driver-x86@xxxxxxxxxxxxxxx" <platform-driver-x86@xxxxxxxxxxxxxxx>, Rajneesh Bhardwaj <rajneesh.bhardwaj@xxxxxxxxx>, Rafael J Wysocki <rjw@xxxxxxxxxxxxx>, Rajat Jain <rajatja@xxxxxxxxxx>, David E Box <david.e.box@xxxxxxxxx>, Mark Gross <markgross@xxxxxxxxxx>
In-reply-to: <CAE2upjS6qRGRcuVYuAB5DMf66A7VcfCKKYEkpsr1My7RnKDFtQ@mail.gmail.com>
References: <20221027151908.v1.1.I295e65357f06f162b46ea6fc6c03be37e3978bdc@changeid> <4b7304c0-8dd5-9add-7c84-4e9f0aa9396b@redhat.com> <MN0PR12MB6101BCCA364437A76FED924AE2339@MN0PR12MB6101.namprd12.prod.outlook.com> <CAG-rBijvNoN3ppz6bdkEUofYPPBxCtFfo1nWBK5TdG69fcKMnA@mail.gmail.com> <CAE2upjS6qRGRcuVYuAB5DMf66A7VcfCKKYEkpsr1My7RnKDFtQ@mail.gmail.com>

On Thu, Oct 27, 2022 at 12:02 PM Rajneesh Bhardwaj
<irenic.rajneesh@xxxxxxxxx> wrote:
> I'd advise against this promotion based on my experience with S0ix entry failures.

On Thu, Oct 27, 2022 at 11:40 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> I'm not a fan of the change you are suggesting here.

Thanks everyone for the feedback. Looks like there is consensus that it's
not advisable to promote the warning. We will move forward with changes to
our monitoring infrastructure instead.

Follow-Ups:
- RE: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN()
  - From: Limonciello, Mario

References:
- [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN()
  - From: Sven van Ashbrook
- Re: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN()
  - From: Hans de Goede
- RE: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN()
  - From: Limonciello, Mario
- Re: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN()
  - From: Sven van Ashbrook

Prev by Date: [Bug 214899] ideapad-laptop: brightness hotkeys not working
Next by Date: [PATCH] platform/x86: asus-tf103c-dock: fix possible memory leak in tf103c_dock_probe()
Previous by thread: Re: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN()
Next by thread: RE: [PATCH v1] platform/x86: intel_pmc_core: promote S0ix failure warn() to WARN()
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Linux USB Devel] [Video for Linux] [Linux Audio Users] [Yosemite News] [Linux Kernel] [Linux SCSI]