On Wed, Sep 28, 2022 at 11:52:51AM +0200, Hans de Goede wrote: > On 9/27/22 22:45, Armin Wolf wrote: > > This patch series adds a new driver for a WMI interface found in > > many newer Dell machines. This interface allows to read battery > > properties like temperature and the ePPID (Dell-specific), while > > also providing fan and thermal sensor information. > > > > The interface does support multiple batteries which are indentified > > by an "index", which appears to be the battery ACPI UID. Since > > the interface also appears to omit any bounts checking of the > > index, the ACPI battery hook mechanism is used to discover batteries. > > > > Since the information returned when querying fan/thermal sensor > > information is currently unknown, a debugfs entry is created to > > allow for easier reverse engineering. The interface is likely > > to be replaced by a proper hwmon interface in the future. > > > > Since the driver can potentially be instantiated multiple times, > > the ACPI battery hook mechanism had to be extended. > > > > The first patch passes a pointer to the battery hook to the > > hook callbacks, so that they can access instance-specific data > > with container_of(). > > > > The second patch finally adds the new driver. It was called > > dell-wmi-ddv since the interface is called "DDV" by Dell software, > > likely meaning "Dell Data Vault". > > > > The driver was tested, together with the changes made to the > > ACPI battery driver, on a Dell Inspiron 3505. Other drivers > > already using the battery hook mechanism where changed as well, > > but could only be compile-tested due to missing hardware. > > > > --- > > Changes in v2: > > - Significantly lower the amount of changes being made to the > > acpi battery driver > > - drop unnecessary ABI description of the temp attribute > > - return 0 when a unsupported battery is found to avoid being > > unloaded > > > > Armin Wolf (2): > > ACPI: battery: Pass battery hook pointer to hook callbacks > > platform/x86: dell: Add new dell-wmi-ddv driver > > Thanks. > > The new version looks good to me: > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > for the series. > > Rafael, from my POV this can be merged through either your > tree or mine. Feel free to merge this through your tree, > or please give your Ack for merging through mine > (assuming you are ok with the changes of course). I gave some comments, but it's up to you if they have to be addressed now or as a follow up. -- With Best Regards, Andy Shevchenko
