Hi Hans, On 9/21/2022 8:12 PM, Hans de Goede wrote: > Hi, > > On 9/21/22 12:24, Shyam Sundar S K wrote: >> AMD PMF driver provides the flexibility to turn "on" or "off" >> CnQF feature (introduced in the earlier patch). >> >> Add corresponding ABI documentation for the new sysfs node and >> also update MAINTAINERS file with this new information >> >> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> >> --- >> Documentation/ABI/testing/sysfs-amd-pmf | 12 ++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 13 insertions(+) >> create mode 100644 Documentation/ABI/testing/sysfs-amd-pmf >> >> diff --git a/Documentation/ABI/testing/sysfs-amd-pmf b/Documentation/ABI/testing/sysfs-amd-pmf >> new file mode 100644 >> index 000000000000..fec2be7178e2 >> --- /dev/null >> +++ b/Documentation/ABI/testing/sysfs-amd-pmf >> @@ -0,0 +1,12 @@ >> +What: /sys/devices/platform/*/cnqf_enable >> +Date: September 2022 >> +Contact: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> >> +Description: Reading this file tells if the AMD Platform Management(PMF) >> + Cool n Quiet Framework(CnQF) feature is enabled or not. >> + >> + This feature is not enabled by default and gets only turned on >> + if OEM BIOS passes a "flag" to PMF ACPI function (index 11 or 12) >> + or in case the user writes "on". >> + >> + To turn off CnQF user can write "off" to the sysfs node. >> + Note: Systems that support auto mode will not have this sysfs file available > > I guess this "available" with a bunch of whitespace in front of it was > intended to be on the next line? > Ah, I missed to notice this. Will fix this in v4. Thanks, Shyam > With this fixed: > > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > Regards, > > Hans > >> diff --git a/MAINTAINERS b/MAINTAINERS >> index d74bf90f5056..255527be7e24 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -1026,6 +1026,7 @@ AMD PMF DRIVER >> M: Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx> >> L: platform-driver-x86@xxxxxxxxxxxxxxx >> S: Maintained >> +F: Documentation/ABI/testing/sysfs-amd-pmf >> F: drivers/platform/x86/amd/pmf/ >> >> AMD HSMP DRIVER >
