Hi again, On 9/10/22 14:15, Hans de Goede wrote: > Hi all, > > On 9/9/22 23:09, Hans de Goede wrote: >> kbd_rgb_mode_groups is only used inside asus-wmi.c, make it static. >> >> Reported-by: kernel test robot <lkp@xxxxxxxxx> >> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > > I've added this to my review-hans (soon to be for-next) branch now. With the typo in the subject fixed. Regards, Hans >> --- >> drivers/platform/x86/asus-wmi.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c >> index d95170b7dba0..ae46af731de9 100644 >> --- a/drivers/platform/x86/asus-wmi.c >> +++ b/drivers/platform/x86/asus-wmi.c >> @@ -835,7 +835,7 @@ static const struct attribute_group kbd_rgb_state_group = { >> .attrs = kbd_rgb_state_attrs, >> }; >> >> -const struct attribute_group *kbd_rgb_mode_groups[] = { >> +static const struct attribute_group *kbd_rgb_mode_groups[] = { >> NULL, >> NULL, >> NULL,