Hi Rafael, Last week I realized that my backlight detect refactor series, which makes sure we only ever register 1 backlight device, breaks the video.disable_backlight_sysfs_if module-param / quirk which is necessary to turn the backlight back on after a suspend / resume cycle on some Toshiba models. This workaround for some Toshiba models relied (in a way) on the old behavior of registering both the acpi and intel backlight class devices in case where acpi_video_get_backlight_type() returned "video". Luckily recently Arvid has started contributing some toshiba_acpi driver improvements and he has an affected Toshiba model. So with the help of Arvid I have been able to come up with a fix for this by pushing the magic firmware call these devices need on resume into toshiba_acpi. After which the whole (no longer functional) disable_backlight_sysfs_if module-parameter can simply be replaced by "standard" acpi_backlight=native DMI quirks for the affected models. I can take care of merging this on top of the backlight-detect-refactor-1 merge already done in the pdx86 tree. Rafael, may I have your ack for merging patch 2/2 through the pdx86 tree? Regards, Hans Hans de Goede (2): drivers/platform: toshiba_acpi: Call HCI_PANEL_POWER_ON on resume on some models ACPI: video: Change disable_backlight_sysfs_if quirks to acpi_backlight=native drivers/acpi/acpi_video.c | 48 ----------------------------- drivers/acpi/video_detect.c | 35 +++++++++++++++++++++ drivers/platform/x86/toshiba_acpi.c | 46 +++++++++++++++++++++++++++ 3 files changed, 81 insertions(+), 48 deletions(-) -- 2.36.1