Re: [PATCH v1 1/1] platform/x86: asus-wmi: Fix name of mic-mute LED classdev

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 8/25/22 10:20, Andy Shevchenko wrote:
> On Thu, Aug 25, 2022 at 3:48 AM PaddyKP_Yao <ispaddy@xxxxxxxxx> wrote:
>>
>> According to well-known-leds.txt, we sould use "platform::micmute"
> 
> should
> 
>> instead of "asus::micmute" for name of mic-mute LED classdev. This patch
> 
> the name
> 
>> fix it into good name.
> 
> a good
> 
> With typos fixed,
> Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>

Thanks, I've fixed up the typos while applying this:

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans




> 
>> Signed-off-by: PaddyKP_Yao <PaddyKP_Yao@xxxxxxxx>
>> ---
>>  drivers/platform/x86/asus-wmi.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
>> index 89b604e04d7f..3acc75c24c79 100644
>> --- a/drivers/platform/x86/asus-wmi.c
>> +++ b/drivers/platform/x86/asus-wmi.c
>> @@ -1118,7 +1118,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
>>         }
>>
>>         if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MICMUTE_LED)) {
>> -               asus->micmute_led.name = "asus::micmute";
>> +               asus->micmute_led.name = "platform::micmute";
>>                 asus->micmute_led.max_brightness = 1;
>>                 asus->micmute_led.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
>>                 asus->micmute_led.brightness_set_blocking = micmute_led_set;
>> --
>> 2.34.1
>>
> 
> 




[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux