Hi,
On 8/24/22 13:09, PaddyKP Yao wrote:
> Hi Pavel,
>
> On Wed, Aug 24, 2022 at 12:06:15PM +0200, Pavel Machek wrote:
>>> drivers/platform/x86/asus-wmi.c | 25 ++++++++++++++++++++++
>>> include/linux/platform_data/x86/asus-wmi.h | 1 +
>>> 3 files changed, 28 insertions(+)
>>>
>>> asus->micmute_led.name = "asus::micmute";
>>
>> Please see/modify well-known-leds.txt file. We want this consistent on all devices.
>
> Thanks for your feedback.
> Do you mean I should use "platform::micmute" instead of "asus::micmute"?
Yes. Since I have already merged your original patch can you please make
this a new patch on top of your original patch ? In other words just
make this 1 small change in the new patch:
diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c
index 2d9d709aa59f..18e584eb9f0f 100644
--- a/drivers/platform/x86/asus-wmi.c
+++ b/drivers/platform/x86/asus-wmi.c
@@ -1060,7 +1060,7 @@ static int asus_wmi_led_init(struct asus_wmi *asus)
}
if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MICMUTE_LED)) {
- asus->micmute_led.name = "asus::micmute";
+ asus->micmute_led.name = "platform::micmute";
asus->micmute_led.max_brightness = 1;
asus->micmute_led.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE);
asus->micmute_led.brightness_set_blocking = micmute_led_set;
Regards,
Hans
