Hi Luke,
On 8/13/22 00:25, Luke D. Jones wrote:
> The dgpu_disable attribute was not documented, this adds the
> required documentation.
>
> Signed-off-by: Luke D. Jones <luke@xxxxxxxxxx>
Thanks for the patch. Note that the Fixes tag should be above your
signed-off-by and then the patch should otherwise have a normal
subject + body. I've changed the commit msg to the following
while merging this:
"""
platform/x86: asus-wmi: Document the dgpu_disable sysfs attribute
The dgpu_disable attribute was not documented, this adds the
required documentation.
Fixes 98829e84dc67 ("asus-wmi: Add dgpu disable method")
Signed-off-by: Luke D. Jones <luke@xxxxxxxxxx>
"""
and I will make similar changes to patch 2/6 and 3/6
> ---
> Documentation/ABI/testing/sysfs-platform-asus-wmi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-platform-asus-wmi b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> index 04885738cf15..0f932fd60f4a 100644
> --- a/Documentation/ABI/testing/sysfs-platform-asus-wmi
> +++ b/Documentation/ABI/testing/sysfs-platform-asus-wmi
> @@ -57,3 +57,12 @@ Description:
> * 0 - default,
> * 1 - overboost,
> * 2 - silent
> +
> +What: /sys/devices/platform/<platform>/dgpu_disable
> +Date: Aug 2022
> +KernelVersion: 5.17
> +Contact: "Luke Jones" <luke@xxxxxxxxxx>
> +Description:
> + Disable discrete GPU:
> + * 0 - Enable dGPU,
> + * 1 - Disable dGPU,
> \ No newline at end of file
Next time please make sure the file always ends with a newline
even in intermediate patches.
Regards,
Hans
