On 08/08/2022 21:34, Peter Kästle wrote:
Hello,
some comments. Please merge if those are considered. Thanks.
On 05.08.22 16:57, Daniel Lezcano wrote:
The thermal framework gives the possibility to register the trip
points with the thermal zone. When that is done, no get_trip_* ops are
needed and they can be removed.
Convert ops content logic into generic trip points and register them
with the
thermal zone.
Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
Acked-by: Peter Kästle <peter@xxxxxxxx>
Thanks for reviewing the patch
[ ... ]
if (kernelmode && prev_interval != interval) {
if (interval > ACERHDF_MAX_INTERVAL) {
pr_err("interval too high, set to %d\n",
I don't know the current behavior of the thermal layer well enough.
Is it ensured, that those new trips[0].temperature / trips[0].hysteresis
values are taken into account?
I don't have this platform so it is hard to test. All the device tree
based sensors are using now those generic trip points and that works.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
