On Tue, 2022-08-09 at 11:29 +0200, Andy Shevchenko wrote: > On Tue, Aug 9, 2022 at 10:56 AM Luke Jones <luke@xxxxxxxxxx> wrote: > > On Tue, Aug 9 2022 at 10:46:33 +0200, Andy Shevchenko > > <andy.shevchenko@xxxxxxxxx> wrote: > > > On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@xxxxxxxxxx> > > > wrote: > > ... > > > > > + err = > > > > asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS, > > > > ASUS_WMI_DEVID_TUF_RGB_MODE, > > > > + rgb->save | (rgb->mode << 8) | > > > > (r > > > > << 16) | (g << 24), > > > > + (b) | (rgb->speed << 8), > > > > > > Too many parentheses. > > > > Uh, yeah. I was unable to find concrete info on this. I at one > > point > > experienced an issue where the order of operations *without* > > parentheses ended up as "x | y << (8 | z) << 16". But now I'm not > > even > > sure if I remember that correctly. I see the order here > > https://www.cs.uic.edu/~i109/Notes/COperatorPrecedenceTable.pdf > > > > I'll do as said and test it to be certain. > > I'm talking about the '(b)' part. The rest is okay to me. > Understood, thanks.
