On Tue, Aug 9, 2022 at 4:51 AM Luke D. Jones <luke@xxxxxxxxxx> wrote: > > This is a patch series to add RGB support for ASUS laptops. > The laptops with this RGB tend to be the TUF series of gamer laptops. > > The first step is initial bringup of support using the multicolor LED API. > > These types of keyboards implement a slightly more complex interface than > just RGB control however - they also have modes with can be static LED, > blinking, rainbow, color cycles, and more. They also have some custom > animations that can play depending on device state, such as suspended > playing a fancy colour cycle, or playing a "wave" animation. > > Two of the patches add support for these features. > > One patch adds documentation in: > Documentation/ABI/testing/sysfs-platform-asus-wmi > for some features that were added previously. > > The final patch adds support for a particular MUX switch found only > on a few ROG laptops. This patch is added to this series due to some > conflicts in merge caused by the RGB patch series. > > Some notes: > > - this patch series obsoletes the previous RGB patches by myself > > - it is not possible to add attribute groups to multicolor LED as > they get overwritten by `led_multicolor_groups` in > `led_classdev_multicolor_register_ext`. > > - the methods for RGB control do not provide a way to fetch exisiting > state, so these methods are WO. > > - There is an existing `asus::kbd_backlight`, this provides a 4-step > brightness to the RGB (off,low,med,high) individually to multicolor. > I was unsure of the effect of adding a similar path so have used the > `asus::multicolour::kbd_backlight` name to be clear about purpose. > If the `asus::kbd_backlight` is off, then no RGB is shown at all. It seems you send too many new versions of the series too fast. Submitting Patches [1] suggest one week gap between series. I would recommend reading that document in full and carefully to understand the Linux kernel process of proposing and submitting changes. [1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#don-t-get-discouraged-or-impatient -- With Best Regards, Andy Shevchenko
