Hi,
On 8/9/22 10:40, Andy Shevchenko wrote:
> On Tue, Aug 9, 2022 at 5:31 AM Luke D. Jones <luke@xxxxxxxxxx> wrote:
>>
>> Add quirk for ASUS ROG X13 Flow 2-in-1 to enable tablet mode with
>> lid flip (all screen rotations).
>
> ...
>
>> { KE_IGNORE, 0xC6, }, /* Ambient Light Sensor notification */
>> { KE_KEY, 0xFA, { KEY_PROG2 } }, /* Lid flip action */
>> + { KE_KEY, 0xBD, { KEY_PROG2 } }, /* Lid flip action on ROG xflow laptops */
>
> Shouldn't you keep it sorted by value?
Actually as I mentioned in my review of v1, we don't want this
addition at all, see:
https://lore.kernel.org/platform-driver-x86/d9d79f9b-f3ab-c07e-9e18-5760ff828487@xxxxxxxxxx/
Regards,
Hans
>
> ...
>
>> #define NOTIFY_KBD_FBM 0x99
>> #define NOTIFY_KBD_TTP 0xae
>> #define NOTIFY_LID_FLIP 0xfa
>> +#define NOTIFY_LID_FLIP_ROG 0xbd
>
> Ditto.
>
> ...
>
>> +static void lid_flip_rog_tablet_mode_get_state(struct asus_wmi *asus)
>> +{
>> + int result;
>> +
>> + result = asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_LID_FLIP_ROG);
>> + if (result >= 0) {
>
> You missed the second part of my comment. Please, read carefully _all_
> reviewer's comments.
>
>> + input_report_switch(asus->inputdev, SW_TABLET_MODE, result);
>> + input_sync(asus->inputdev);
>> + }
>> +}
>
> ...
>
> Overall, it's getting better!
>
