On Mon, Aug 8, 2022 at 5:07 AM Luke D. Jones <luke@xxxxxxxxxx> wrote:
>
> Adds support for changing the laptop keyboard LED modes. These
> are visible effects such as static, rainbow, pulsing, colour cycles.
>
> Two sysfs attributes are added to asus-nb-wmi:
> - keyboard_rgb_mode
> - keyboard_rgb_mode_index
...
> + if (sscanf(buf, "%hhd %hhd %hhd", &save, &mode, &speed) != 3)
> + return -EINVAL;
Same comment as per v1.
...
> + asus->keyboard_rgb_mode.mode = mode < 12 && mode != 9 ? mode : 0x0a;
Same comment as per v1.
...
> + switch (speed) {
> + case 0:
> + asus->keyboard_rgb_mode.speed = 0xe1;
> + break;
> + case 1:
> + asus->keyboard_rgb_mode.speed = 0xeb;
> + break;
> + case 2:
> + asus->keyboard_rgb_mode.speed = 0xf5;
> + break;
> + default:
> + asus->keyboard_rgb_mode.speed = 0xeb;
break;
> + }
...
> +
A blank line is not needed here.
> +static DEVICE_ATTR_WO(keyboard_rgb_mode);
--
With Best Regards,
Andy Shevchenko
