On Mon, Aug 8, 2022 at 5:12 AM Luke D. Jones <luke@xxxxxxxxxx> wrote:
>
> Add quirk for ASUS ROG X13 Flow 2-in-1 to enable tablet mode with
> lid flip (all screen rotations).
...
> - { KE_KEY, 0xFA, { KEY_PROG2 } }, /* Lid flip action */
> + { KE_KEY, 0xFA, { KEY_PROG2 } }, /* Lid flip action */
Have maintainers asked you about this? Otherwise it is irrelevant change.
...
> + pr_err("This device has lid-flip-rog quirk but got ENODEV checking it. This is a bug.");
dev_err() ?
...
> + pr_err("Error checking for lid-flip: %d\n", result);
Ditto.
...
> +static void lid_flip_rog_tablet_mode_get_state(struct asus_wmi *asus)
> +{
> + int result = asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_LID_FLIP_ROG);
> +
> + if (result >= 0) {
First of all, it's better to decouple assignment and definition, and
move assignment closer to its user. This is usual pattern.
int result;
result = ...
if (result...)
> + input_report_switch(asus->inputdev, SW_TABLET_MODE, result);
> + input_sync(asus->inputdev);
> + }
Second, it will look better with standard pattern of checking for errors, i.e.
int result;
if (result < 0)
return;
...
> +}
--
With Best Regards,
Andy Shevchenko
