Hi, On 7/21/22 14:11, Maximilian Luz wrote: > The 13" Intel version of the Surface Laptop 4 uses the same GPE as the > Surface Laptop Studio for wakeups via the lid. Set it up accordingly. > > Signed-off-by: Maximilian Luz <luzmaximilian@xxxxxxxxx> Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > --- > drivers/platform/surface/surface_gpe.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/drivers/platform/surface/surface_gpe.c b/drivers/platform/surface/surface_gpe.c > index 27365cbe1ee9..c219b840d491 100644 > --- a/drivers/platform/surface/surface_gpe.c > +++ b/drivers/platform/surface/surface_gpe.c > @@ -171,6 +171,18 @@ static const struct dmi_system_id dmi_lid_device_table[] = { > }, > .driver_data = (void *)lid_device_props_l4D, > }, > + { > + .ident = "Surface Laptop 4 (Intel 13\")", > + .matches = { > + /* > + * We match for SKU here due to different variants: The > + * AMD (15") version does not rely on GPEs. > + */ > + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"), > + DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "Surface_Laptop_4_1950:1951"), > + }, > + .driver_data = (void *)lid_device_props_l4B, > + }, > { > .ident = "Surface Laptop Studio", > .matches = {