Hi, On 7/10/22 16:07, Hans de Goede wrote: > A recent suggested change to the IFS code has shown that the userspace > API needs a bit more work, see: > https://lore.kernel.org/platform-driver-x86/20220708151938.986530-1-jithu.joseph@xxxxxxxxx/ > > Mark it as BROKEN before 5.19 ships, to give ourselves one more > kernel-devel cycle to get the userspace API right. > > Link: https://lore.kernel.org/platform-driver-x86/20220708151938.986530-1-jithu.joseph@xxxxxxxxx/ > Cc: Jithu Joseph <jithu.joseph@xxxxxxxxx> > Cc: Ashok Raj <ashok.raj@xxxxxxxxx> > Cc: Tony Luck <tony.luck@xxxxxxxxx> > Suggested-by: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> I've added this to my review-hans (soon to be for-next) branch now. Regards, Hans > --- > drivers/platform/x86/intel/ifs/Kconfig | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/platform/x86/intel/ifs/Kconfig b/drivers/platform/x86/intel/ifs/Kconfig > index 7ce896434b8f..c341a27cc1a3 100644 > --- a/drivers/platform/x86/intel/ifs/Kconfig > +++ b/drivers/platform/x86/intel/ifs/Kconfig > @@ -1,6 +1,9 @@ > config INTEL_IFS > tristate "Intel In Field Scan" > depends on X86 && CPU_SUP_INTEL && 64BIT && SMP > + # Discussion on the list has shown that the sysfs API needs a bit > + # more work, mark this as broken for now > + depends on BROKEN > select INTEL_IFS_DEVICE > help > Enable support for the In Field Scan capability in select
