On Fri, Jun 24, 2022 at 01:23:33PM +0200, Hans de Goede wrote:
> Hi All,
>
> Here is a series fixing the missing keypresses on some Panasonic Toughbook
> models. These missing keypresses are caused by
> commit ed83c9171829 ("platform/x86: panasonic-laptop: Resolve hotkey double
> trigger bug"), which made the panasonic-laptop driver unconditionally drop
> most WMI reported hotkeys.
>
> This series reverts that commit and then adds some more selective filtering
> to still avoid the double key-presses on some models, while avoiding
> completely missing keypresses on others.
>
> Rafael, these fixes rely on patch 1/7, which is a tweak to
> the acpi_video_handles_brightness_key_presses() helper. Without this
> tweak this series will cause a regression, so I would like to merge
> the entire series through the pdx86 tree, may I have your ack for this?
I followed this series on Bugzilla,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
with or without my comments addressed (they are optional)
> Regards,
>
> Hans
>
>
> Hans de Goede (6):
> ACPI: video: Change how we determine if brightness key-presses are
> handled
> platform/x86: panasonic-laptop: sort includes alphabetically
> platform/x86: panasonic-laptop: revert "Resolve hotkey double trigger
> bug"
> platform/x86: panasonic-laptop: don't report duplicate brightness
> key-presses
> platform/x86: panasonic-laptop: filter out duplicate volume
> up/down/mute keypresses
> platform/x86: panasonic-laptop: Use acpi_video_get_backlight_type()
>
> Stefan Seyfried (1):
> platform/x86: panasonic-laptop: de-obfuscate button codes
>
> drivers/acpi/acpi_video.c | 13 ++-
> drivers/platform/x86/Kconfig | 2 +
> drivers/platform/x86/panasonic-laptop.c | 112 ++++++++++++++++++------
> 3 files changed, 91 insertions(+), 36 deletions(-)
>
> --
> 2.36.0
>
--
With Best Regards,
Andy Shevchenko
