On Fri, Jun 24, 2022 at 01:23:34PM +0200, Hans de Goede wrote: > Some systems have an ACPI video bus but not ACPI video devices with > backlight capability. On these devices brightness key-presses are > (logically) not reported through the ACPI video bus. > > Change how acpi_video_handles_brightness_key_presses() determines if > brightness key-presses are handled by the ACPI video driver to avoid > vendor specific drivers/platform/x86 drivers filtering out their > brightness key-presses even though they are the only ones reporting > these presses. ... > - return have_video_busses && > + return has_backlight && > (report_key_events & REPORT_BRIGHTNESS_KEY_EVENTS); I would combine on one line. -- With Best Regards, Andy Shevchenko