[Bug 213297] ideapad-laptop: DYTC interface not found, several functionalities missing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.kernel.org/show_bug.cgi?id=213297

Hans de Goede (jwrdegoede@xxxxxxxxxxxxxxxxx) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwrdegoede@xxxxxxxxxxxxxxxx
                   |                            |g

--- Comment #8 from Hans de Goede (jwrdegoede@xxxxxxxxxxxxxxxxx) ---
(In reply to Luis O from comment #7)
> I came across this issue, and I checked the ideapad-acpi source code and for
> some reason it now allows DYTC version 4, but only for 1 laptop model. 
> https://github.com/torvalds/linux/blob/
> ca1fdab7fd27eb069df1384b2850dcd0c2bebe8d/drivers/platform/x86/ideapad-laptop.
> c#L871

Right, this is done because we don't know if DYTC version 4 will work on all
models. The ideapad platform-profile code was based on the ThinkPad code
contibuted by Lenovo and that was for version 5.

So for now we only allow using v4 on tested devices.

What would be good is to add a module parameter to allow using the
platform-profile code on v4 devices for easier testing. If you can submit a
patch to do that that would be great.

Or if you're not into writing kernel patches, I can write such a patch and then
you can test it on your model. Note this will require you to build your own
kernel from source.

And if the testing of the patch also shows that your model works correctly,
then your model can also be added to the list of devices on which using v4 DYTC
support is allowed (and eventually if that list becomes quite big we may choose
to enable this by default).

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux