On Mon, Jun 20, 2022 at 4:56 PM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > drivers/platform/x86/Kconfig is wrapped in one big > if X86_PLATFORM_DEVICES .. endif and X86_PLATFORM_DEVICES already > has a "depends on X86" so the "if X86" in drivers/platform/Kconfig > is not necessary and except for mips non of the other includes MIPS none ? > there has such an if. So lets remove it. let's > While at it also move the x86/Kconfig include to the end of the file > for alphabetical sorting. Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > Changes in v2: > - Drop "if X86" from drivers/platform/Kconfig instead of dropping the > "depends on X86" from X86_PLATFORM_DEVICES > --- > drivers/platform/Kconfig | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/Kconfig b/drivers/platform/Kconfig > index 18fc6a08569e..b437847b6237 100644 > --- a/drivers/platform/Kconfig > +++ b/drivers/platform/Kconfig > @@ -1,7 +1,4 @@ > # SPDX-License-Identifier: GPL-2.0-only > -if X86 > -source "drivers/platform/x86/Kconfig" > -endif > if MIPS > source "drivers/platform/mips/Kconfig" > endif > @@ -15,3 +12,5 @@ source "drivers/platform/mellanox/Kconfig" > source "drivers/platform/olpc/Kconfig" > > source "drivers/platform/surface/Kconfig" > + > +source "drivers/platform/x86/Kconfig" > -- > 2.36.0 > -- With Best Regards, Andy Shevchenko