On Mon, Jun 20, 2022 at 11:36 AM Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > > ACER_WMI already depends on ACPI_WMI which depends on ACPI > so the "depends on ACPI" is unnecessary. > > And since ACER_WMI already depends on ACPI adding an "if ACPI" > to the ACPI_VIDEO select is non-sense. nonsense > While at it also group all the selects together. Reviewed-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> > --- > drivers/platform/x86/Kconfig | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 08852a1cd51d..6e22ac916f7a 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -177,17 +177,15 @@ config ACER_WIRELESS > > config ACER_WMI > tristate "Acer WMI Laptop Extras" > - depends on ACPI > - select LEDS_CLASS > - select NEW_LEDS > depends on BACKLIGHT_CLASS_DEVICE > depends on SERIO_I8042 > depends on INPUT > depends on RFKILL || RFKILL = n > depends on ACPI_WMI > + select ACPI_VIDEO > select INPUT_SPARSEKMAP > - # Acer WMI depends on ACPI_VIDEO when ACPI is enabled > - select ACPI_VIDEO if ACPI > + select LEDS_CLASS > + select NEW_LEDS > help > This is a driver for newer Acer (and Wistron) laptops. It adds > wireless radio and bluetooth control, and on some laptops, > -- > 2.36.0 > -- With Best Regards, Andy Shevchenko
