On Thu, Jun 9, 2022 at 5:49 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > > On Thu, Jun 09, 2022 at 04:09:45PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > > > Instead of walking the list of children of an ACPI device directly, > > use acpi_dev_for_each_child() to carry out an action for all of > > the given ACPI device's children. > > ... > > > + rc = acpi_dev_for_each_child(device, tpacpi_evaluate_bcl, NULL); > > + if (rc > 0) > > + return rc; > > > > + return 0; > > It can be simply 'return acpi_dev_for_each_child();', no? It can. > AFAICS the caller is prepared for negative returns. It will not return negative though unless the ACPI tables are horribly broken.
