Re: [PATCH v2] platform/x86: Move AMD platform drivers to separate directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 8, 2022 at 8:23 PM Shyam Sundar S K
<Shyam-sundar.S-k@xxxxxxx> wrote:
>
> Currently, AMD supported platform drivers are grouped under generic "x86"
> folder structure. Move the current drivers (amd-pmc and amd_hsmp) to a
> separate directory. This would also mean the newer driver submissions to
> pdx86 subsystem in the future will also land in AMD specific directory.

...

> +obj-$(CONFIG_AMD_PMC)          += pmc.o
> +obj-$(CONFIG_AMD_HSMP)         += hsmp.o

This will make a potential collision if there will be a module with
the same name, but in a different folder.  Also this breaks a kernel
command line (in case of built-in). Dunno if the latter is important,
though.

I mentioned a trick that has been used in drivers/platform/x86/intel/Makefile.

-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Linux Kernel Development]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux