Am Wed, 11 May 2022 11:03:04 -0700 schrieb Guenter Roeck <linux@xxxxxxxxxxxx>: > On 5/11/22 08:39, Henning Schild wrote: > > Since we have a common P2SB accessor in tree we may use it instead > > of open coded variants. > > > > Replace custom code by p2sb_bar() call. > > > > Signed-off-by: Henning Schild <henning.schild@xxxxxxxxxxx> > > --- > > drivers/watchdog/Kconfig | 1 + > > drivers/watchdog/simatic-ipc-wdt.c | 15 ++++++++------- > > 2 files changed, 9 insertions(+), 7 deletions(-) > > > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > > index c4e82a8d863f..643a8f5a97b1 100644 > > --- a/drivers/watchdog/Kconfig > > +++ b/drivers/watchdog/Kconfig > > @@ -1628,6 +1628,7 @@ config SIEMENS_SIMATIC_IPC_WDT > > tristate "Siemens Simatic IPC Watchdog" > > depends on SIEMENS_SIMATIC_IPC > > select WATCHDOG_CORE > > + select P2SB if X86 > > Why "if X86" ? SIEMENS_SIMATIC_IPC already depends on it. Thanks, will remove that. > Also, I just noticed that P2SB is neither in mainline nor > in linux-next, meaning this code won't even compile right now. > That should be mentioned in the introduction e-mail (the use > of "introduced" suggests that it is already there; you could > just use "will be introduced" instead). It was kind of in the cover letter, but maybe not verbose enough. Sorry for the confusion. v1 was sent in-reply-to on top of P2SB, maybe i will do that again for v3 but for sure point out the order in case i send it without the reply. Thanks, Henning > Thanks, > Guenter
