Hi Hans,
On Wed, 2022-05-11 at 17:56 +0200, Hans de Goede wrote:
> Hi,
>
> On 5/10/22 04:34, Srinivas Pandruvada wrote:
> > For Intel SST turbo-freq feature to be enabled, the turbo mode on
> > the
> > platform must be enabled also. If turbo mode is disabled, display
> > error
> > while enabling turbo-freq feature.
> >
> > Signed-off-by: Srinivas Pandruvada
> > <srinivas.pandruvada@xxxxxxxxxxxxxxx>
> > ---
> > Since this is a trivial patch, I am not sending a PULL request.
>
> Note not related to this patch, but when test building intel-speed-
> select
> I got the following compiler warning:
>
> CC hfi-events.o
> In function ‘process_hfi_event’,
> inlined from ‘handle_event’ at hfi-events.c:220:5:
> hfi-events.c:184:9: warning: ‘perf_cap.cpu’ may be used uninitialized
> [-Wmaybe-uninitialized]
> 184 | process_level_change(perf_cap->cpu);
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> hfi-events.c: In function ‘handle_event’:
> hfi-events.c:193:25: note: ‘perf_cap.cpu’ was declared here
> 193 | struct perf_cap perf_cap;
> | ^~~~~~~~
>
>
Let me send a patch to fix. In reality this will not happen as HFI
message will always have a CPU.
Thanks,
Srinivas
> Regards,
>
> Hans
>
>
>
> >
> > tools/power/x86/intel-speed-select/isst-config.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/tools/power/x86/intel-speed-select/isst-config.c
> > b/tools/power/x86/intel-speed-select/isst-config.c
> > index 060390e88e37..9d35614995ee 100644
> > --- a/tools/power/x86/intel-speed-select/isst-config.c
> > +++ b/tools/power/x86/intel-speed-select/isst-config.c
> > @@ -1892,6 +1892,12 @@ static void set_fact_for_cpu(int cpu, void
> > *arg1, void *arg2, void *arg3,
> > int ret;
> > int status = *(int *)arg4;
> >
> > + if (status && no_turbo()) {
> > + isst_display_error_info_message(1, "Turbo mode is
> > disabled", 0, 0);
> > + ret = -1;
> > + goto disp_results;
> > + }
> > +
> > ret = isst_get_ctdp_levels(cpu, &pkg_dev);
> > if (ret) {
> > isst_display_error_info_message(1, "Failed to get
> > number of levels", 0, 0);
>
