Hi, On 5/10/22 04:34, Srinivas Pandruvada wrote: > For Intel SST turbo-freq feature to be enabled, the turbo mode on the > platform must be enabled also. If turbo mode is disabled, display error > while enabling turbo-freq feature. > > Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> > --- > Since this is a trivial patch, I am not sending a PULL request. Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > > tools/power/x86/intel-speed-select/isst-config.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/power/x86/intel-speed-select/isst-config.c b/tools/power/x86/intel-speed-select/isst-config.c > index 060390e88e37..9d35614995ee 100644 > --- a/tools/power/x86/intel-speed-select/isst-config.c > +++ b/tools/power/x86/intel-speed-select/isst-config.c > @@ -1892,6 +1892,12 @@ static void set_fact_for_cpu(int cpu, void *arg1, void *arg2, void *arg3, > int ret; > int status = *(int *)arg4; > > + if (status && no_turbo()) { > + isst_display_error_info_message(1, "Turbo mode is disabled", 0, 0); > + ret = -1; > + goto disp_results; > + } > + > ret = isst_get_ctdp_levels(cpu, &pkg_dev); > if (ret) { > isst_display_error_info_message(1, "Failed to get number of levels", 0, 0);
